Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.7 support #30963

Merged
merged 1 commit into from
May 29, 2023
Merged

Remove Python 3.7 support #30963

merged 1 commit into from
May 29, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Apr 29, 2023


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk force-pushed the remove-python-3-7 branch 8 times, most recently from 52eb8a0 to f3e1370 Compare May 6, 2023 10:18
@potiuk potiuk force-pushed the remove-python-3-7 branch from f3e1370 to 5025551 Compare May 8, 2023 18:28
@potiuk potiuk force-pushed the remove-python-3-7 branch 5 times, most recently from 3b7755b to d2b630a Compare May 16, 2023 21:51
@potiuk potiuk force-pushed the remove-python-3-7 branch 6 times, most recently from fb34582 to fa520f7 Compare May 21, 2023 19:35
@potiuk potiuk force-pushed the remove-python-3-7 branch 2 times, most recently from e0a3415 to 504b6d1 Compare May 25, 2023 00:21
CI.rst Outdated Show resolved Hide resolved
@potiuk potiuk force-pushed the remove-python-3-7 branch 2 times, most recently from 5fcec82 to 8a0d637 Compare May 29, 2023 01:16
@potiuk potiuk marked this pull request as ready for review May 29, 2023 01:17
@potiuk
Copy link
Member Author

potiuk commented May 29, 2023

Marked as "Ready for review" - should be such and I guess we can merged it soon after @eladkal's lazy consensus.

The doubt was raised whether the providers should be 3.8+ only as well - I believe so, it's the same reason we speed up the removal in CI, so providers should be 3.8+ as well IMHO.

@potiuk potiuk force-pushed the remove-python-3-7 branch 2 times, most recently from 3234d75 to 2cb0b3b Compare May 29, 2023 02:02
@eladkal
Copy link
Contributor

eladkal commented May 29, 2023

The doubt was raised whether the providers should be 3.8 only as well - I believe so

They should be 3.8+

@potiuk
Copy link
Member Author

potiuk commented May 29, 2023

So - it's all green, ready to final review and merge :)

@potiuk potiuk force-pushed the remove-python-3-7 branch from 2cb0b3b to 299f8d0 Compare May 29, 2023 07:19
@potiuk potiuk force-pushed the remove-python-3-7 branch from 299f8d0 to 5eb2e83 Compare May 29, 2023 07:25
@potiuk potiuk merged commit 9fa75aa into main May 29, 2023
@pankajkoti
Copy link
Member

Just wish to check if we need to tag this to some milestone and if need to also apply the pinned label like in PR #27264?

@potiuk
Copy link
Member Author

potiuk commented May 29, 2023

Just wish to check if we need to tag this to some milestone and if need to also apply the pinned label like in PR #27264?

No need. We are not cherry-picking it to 2.6 (so by default it goes to next major relase). And pinned was really there to make sure the 3.11 PR is not closed automatically by the stalebot (the 3.11 was opened in October and it has long period of waiting for dependencies to catch up, so I wanted to make sure stalebot will not close it. The "pinned" label is specifically for stalebot.

@raphaelauv
Copy link
Contributor

README of branch main is no more showing 3.7 as a valide version for 2.6.1

Screenshot from 2023-05-29 12-53-21

Is that voluntary ?

@potiuk
Copy link
Member Author

potiuk commented May 29, 2023

README of branch main is no more showing 3.7 as a valide version for 2.6.1

Screenshot from 2023-05-29 12-53-21

Is that voluntary ?

Nope. mistake.

@potiuk
Copy link
Member Author

potiuk commented May 29, 2023

Fix in #31592

@pierrejeambrun pierrejeambrun added this to the Airflow 2.7.0 milestone May 29, 2023
@pankajkoti
Copy link
Member

Just wish to check if we need to tag this to some milestone and if need to also apply the pinned label like in PR #27264?

No need. We are not cherry-picking it to 2.6 (so by default it goes to next major relase). And pinned was really there to make sure the 3.11 PR is not closed automatically by the stalebot (the 3.11 was opened in October and it has long period of waiting for dependencies to catch up, so I wanted to make sure stalebot will not close it. The "pinned" label is specifically for stalebot.

Okay, understood, nice. Checked it here now that how we save such PRs from the Stalebot here: https://github.com/apache/airflow/blob/main/.github/workflows/stale.yml#L40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants