Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template extra volumes in helm chart #30773

Merged
merged 13 commits into from
Jun 21, 2023
Merged

Conversation

nirroz93
Copy link
Contributor

same as #29357


Same as #29357, seems like it was missed
^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Apr 20, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 20, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@nirroz93 nirroz93 force-pushed the patch-1 branch 3 times, most recently from 17b6d57 to aa19ec9 Compare April 20, 2023 18:00
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the PR you mention, the values file was updated by adding an example for each extra volumes field and adding a comment before the example:

It can be templated like in the following example:

You need to do the same thing for gitSync, dagProcessor, flower, createUserJob and pgbouncer?

@nirroz93 nirroz93 requested a review from hussein-awala April 24, 2023 17:47
Copy link
Member

@jedcunningham jedcunningham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay here @nirroz93. This looks good. Can you resolve the conflict so I can get this merged? Thanks!

@nirroz93
Copy link
Contributor Author

nirroz93 commented Jun 2, 2023

@jedcunningham - done, thank you!

chart/values.yaml Outdated Show resolved Hide resolved
@jedcunningham
Copy link
Member

@hussein-awala, want to take another look?

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jedcunningham
Copy link
Member

Looks like static checks and one test are failing. I'd suggest that you set up the pre-commit hooks, they help catch the static check issues early 👍.

@eladkal
Copy link
Contributor

eladkal commented Jun 18, 2023

@nirroz93 can you address the failing static tests?

@nirroz93
Copy link
Contributor Author

nirroz93 commented Jun 18, 2023

Yes, I will look at it later today (sorry for disappearing)

@eladkal eladkal added this to the Airflow Helm Chart 1.10.0 milestone Jun 19, 2023
@jedcunningham jedcunningham merged commit 2508787 into apache:main Jun 21, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 21, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

@jedcunningham
Copy link
Member

Thanks @nirroz93! Congrats on your first commit 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants