-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template extra volumes in helm chart #30773
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
17b6d57
to
aa19ec9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in the PR you mention, the values file was updated by adding an example for each extra volumes field and adding a comment before the example:
It can be templated like in the following example:
You need to do the same thing for gitSync
, dagProcessor
, flower
, createUserJob
and pgbouncer
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay here @nirroz93. This looks good. Can you resolve the conflict so I can get this merged? Thanks!
@jedcunningham - done, thank you! |
@hussein-awala, want to take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Looks like static checks and one test are failing. I'd suggest that you set up the pre-commit hooks, they help catch the static check issues early 👍. |
@nirroz93 can you address the failing static tests? |
Yes, I will look at it later today (sorry for disappearing) |
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Thanks @nirroz93! Congrats on your first commit 🎉 |
same as #29357
Same as #29357, seems like it was missed
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.