-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to MyPy 1.2.0 #30687
Upgrade to MyPy 1.2.0 #30687
Conversation
Upgrading to latest (released a week ago) MyPy in the hopes it will fix some more problem with attrs after upgrading new packages, but it seems that even the latest MyPy does not know about the new typing changes introduced in attrs (traditionally mypy has attrs plugin that injects appropriate typing but apparently it needs to catch up with those changes.
Seems that mypy in our main after some more (unrelated) upgraded packages started failing. They seem unrelated, but hey, it's MyPy and it's heuristing on when to start complaining about things that seemed to be ok earlier after some unrelated changes is something that we all got used to I think,
Here is the failure: https://github.com/apache/airflow/actions/runs/4724060012/jobs/8381284205 Those were the change deps:
And after upgrading those, mypy provider checks resulted in:
I upgraded mypy toi 1.2.0 in the hopes it will understand attrs a bit better, but this resulted in few more errors related to attrs (and some other small things I fixed in Pydantic AIP-44 classes:
Unless we have a better idea (@uranusjr ?) temporary ignoring those, seem to be the best way (And as a bonus we wil have latest-and-greatest MyPy. |
Upgrading to latest (released a week ago) MyPy in the hopes it will fix some more problem with attrs after upgrading new packages, but it seems that even the latest MyPy does not know about the new typing changes introduced in attrs (traditionally mypy has attrs plugin that injects appropriate typing but apparently it needs to catch up with those changes.
Upgrading to latest (released a week ago) MyPy in the hopes it will fix some more problem with attrs after upgrading new packages, but it seems that even the latest MyPy does not know about the new typing changes introduced in attrs (traditionally mypy has attrs plugin that injects appropriate typing but apparently it needs to catch up with those changes.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.