Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AzureDataLakeStorageV2Hook with Active Directory authentication #29981

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

adamwhitneysoftwire
Copy link
Contributor

Uses the host field from the connection to populate the account_url that is sent to DataLakeServiceClient.

Previously used the login field, which when using Active Directory authentication is set to the Client ID. This is incorrect as the dfs URL should be of the format https://{storage_account}.dfs.core.windows.net.

closes: #29980

@boring-cyborg
Copy link

boring-cyborg bot commented Mar 8, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@potiuk potiuk merged commit 008f524 into apache:main Mar 10, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 10, 2023

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants