Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AirbyteHook add cancel job option #24593

Merged
merged 13 commits into from
Jun 29, 2022
Merged

AirbyteHook add cancel job option #24593

merged 13 commits into from
Jun 29, 2022

Conversation

sivankumar86
Copy link
Contributor

@sivankumar86 sivankumar86 commented Jun 22, 2022

closes: #24574


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Jun 22, 2022

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@uranusjr uranusjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please fix static check errors.

airflow/providers/airbyte/operators/airbyte.py Outdated Show resolved Hide resolved
uranusjr
uranusjr previously approved these changes Jun 22, 2022
@uranusjr uranusjr dismissed their stale review June 22, 2022 05:40

We should have a test for this

@eladkal eladkal changed the title 24574 job cancel is added if task is cancelled AirbyteHook add cancel job option Jun 22, 2022
@sivankumar86
Copy link
Contributor Author

@uranusjr Thank you for reviewing the changes and feedback. Could you review the latest commit ?

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jun 22, 2022
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.

@sivankumar86
Copy link
Contributor Author

@uranusjr is there anything pending from my side ?

@uranusjr
Copy link
Member

No; we need a second reviewer’s approval here to merge (project policy), so all we can do for now is to wait.

@potiuk
Copy link
Member

potiuk commented Jun 23, 2022

No; we need a second reviewer’s approval here to merge (project policy), so all we can do for now is to wait.

Actually @uranusjr - the policy is only for core changes - not providers. Providers are cool to merge with one committer. I often do so - anyhow there is always additional step of verification at release candidate time when I ask people to test their changes so we have this extra "gate" before release.

@sivankumar86 - you actually need to fix things. static checks and test are failing and it seems relevant to your changes. Install pre-commit and it will fix the static checks for you mostly.

@sivankumar86
Copy link
Contributor Author

No; we need a second reviewer’s approval here to merge (project policy), so all we can do for now is to wait.

Actually @uranusjr - the policy is only for core changes - not providers. Providers are cool to merge with one committer. I often do so - anyhow there is always additional step of verification at release candidate time when I ask people to test their changes so we have this extra "gate" before release.

@sivankumar86 - you actually need to fix things. static checks and test are failing and it seems relevant to your changes. Install pre-commit and it will fix the static checks for you mostly.

@potiuk Thank you for your feedback and update. Could you review and approve it ?

@sivankumar86
Copy link
Contributor Author

@uranusjr Could you please approve the workflow ?

@potiuk
Copy link
Member

potiuk commented Jun 29, 2022

Timeout on sdist building has been fixed in main already. Merging.

@potiuk potiuk merged commit c118b28 into apache:main Jun 29, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 29, 2022

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AirbyteHook add cancel job option
3 participants