Update providers to use functools compat for cached_property
#24582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
provider:cncf-kubernetes
|
WOOOOHOOO! the benefits of deprecation removals :). |
potiuk
approved these changes
Jun 21, 2022
Merged
github-actions
bot
added
the
okay to merge
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
uranusjr
approved these changes
Jun 21, 2022
josh-fell
force-pushed
the
cached-prop-use-compat
branch
from
b232af9 to
213889c
Compare
jedcunningham
approved these changes
Jun 21, 2022
blag
approved these changes
Jun 21, 2022
Comment on lines
+21
to
22
| from kubernetes import client, config, watch | ||
| from kubernetes.config import ConfigException |
There was a problem hiding this comment.
Ignorable nit: kubernetes.config is kinda sorta being imported twice.
There was a problem hiding this comment.
Yeah you're right. The import cleanup was a little bit me, but mostly isort. I can't take all the credit 🙂
95 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that all providers have a minimum Airflow version of 2.2.0,
cached_propertyreferences should be replaced withairflow.compat.functools.cached_propertyusage. This module was introduced with 2.2.0.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.