Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TrinoOperator #24415

Merged
merged 2 commits into from
Jun 19, 2022
Merged

Add TrinoOperator #24415

merged 2 commits into from
Jun 19, 2022

Conversation

phanikumv
Copy link
Contributor

@phanikumv phanikumv commented Jun 13, 2022

This PR adds a TrinoOperator to enable submitting SQL to the Trino Query Engine.

cc @kaxil @ashb


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named {pr_number}.significant.rst, in newsfragments.

@kaxil
Copy link
Member

kaxil commented Jun 14, 2022

@phanikumv phanikumv force-pushed the trino_op branch 2 times, most recently from 1757541 to b53e58a Compare June 16, 2022 10:05
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @kaxil @eladkal ?

@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jun 19, 2022
@potiuk potiuk merged commit 865406c into apache:main Jun 19, 2022
kaxil pushed a commit that referenced this pull request Jun 20, 2022
This PR is a follow up to PR #24415.
It adds on_kill method to the TrinoOperator to kill Trino query if Airflow task is killed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers full tests needed We need to run full set of tests for this PR to merge kind:documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants