-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: RedshiftDataHook and RdsHook not use cached connection #24387
Conversation
331eb02
to
8458542
Compare
LGTM. @ferruzzi @o-nikolas WDYT? |
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
I've just wondering that in amazon-provider Lines 201 to 202 in dfdf8eb
|
Not really. Mypy Section is for "generic" mypuy dependencies that are required for Arflow "core" (in development but still). We are likely going to reshuffle deps soon, preparing to splitting providers from Airlflow core and the "amazon" specific dependencies will land in setup.py of amazon provider eventually - they will be completely removed from the "airflow" setup.py. So it's better to keep them where they are for now. We are going to likely make also each provider to have their own |
soon = few months from now. I am gearing up to write detailed description/AIP of what's needed there (I will ask for help on reviewing and finalizing when I get there). |
After finding in this PR: #24057 (comment) I've checked other AWS Hooks which not use cached
conn
property and found two hooksRedshiftDataHook
andRdsHook
Add to
AwsBaseHook
generic connection, so it won't required anymore overwriteconn
propertyType hinting still work in IDE (PyCharm) after changes