Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dag_ids parameter optional for dagStats REST API #41495

Closed
1 of 2 tasks
reganbaum opened this issue Aug 15, 2024 · 11 comments · Fixed by #42955
Closed
1 of 2 tasks

Make dag_ids parameter optional for dagStats REST API #41495

reganbaum opened this issue Aug 15, 2024 · 11 comments · Fixed by #42955
Assignees
Labels
area:API Airflow's REST/HTTP API contributors-workshop Issues that are good for first-time contributor's workshop good first issue kind:feature Feature Requests

Comments

@reganbaum
Copy link

Description

Today, the dagStats REST API requires a list of dag_ids as input.

Can we make this parameter optional, so that if no dag_ids are provided, it will return all the stats of all the dags? This is the current behavior of the dag_stats endpoint, so it'd be good to have parity with the REST API so that the UI could use this same REST API in the future.

Use case/motivation

Clients should be able to make a REST API call to get all the dag stats without requiring specific dag ids.

Related issues

#41017 (see specific discussion in the PR here: #41017 (comment))

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@reganbaum reganbaum added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Aug 15, 2024
@dosubot dosubot bot added the area:API Airflow's REST/HTTP API label Aug 15, 2024
@kaxil kaxil added good first issue and removed needs-triage label for new issues that we didn't triage yet labels Aug 16, 2024
@dondaum
Copy link
Contributor

dondaum commented Aug 16, 2024

I would be happy to help with this one again.

@dondaum
Copy link
Contributor

dondaum commented Aug 26, 2024

Friendly reminder.

@Yusin0903
Copy link

Hi, Can I try this issue?

@potiuk
Copy link
Member

potiuk commented Sep 5, 2024

Feel free to collaborate on that one @dondaum @Yusin0903

@dondaum
Copy link
Contributor

dondaum commented Sep 6, 2024

@Yusin0903 I've already contributed to a similar feature request. So from my side you can take care of this and I can help you if you need help. What do you think?

@Yusin0903
Copy link

Yusin0903 commented Sep 6, 2024

@dondaum ok, thank you! I will try it.

@RNHTTR RNHTTR added the contributors-workshop Issues that are good for first-time contributor's workshop label Sep 11, 2024
@Yusin0903 Yusin0903 removed their assignment Oct 7, 2024
@Yusin0903
Copy link

@dondaum Hi, because I am busy recently. I think I can not do it so well. Can u continue executing it?

@dondaum
Copy link
Contributor

dondaum commented Oct 8, 2024

@dondaum Hi, because I am busy recently. I think I can not do it so well. Can u continue executing it?

Sure. I will take this one over.

@michaeljs-c
Copy link
Contributor

Hi @dondaum I'm looking to make my first contribution. Could I take part in this one?

@dondaum
Copy link
Contributor

dondaum commented Oct 9, 2024

Hi @dondaum I'm looking to make my first contribution. Could I take part in this one?

Sure. I think it is hard to split it up. So from my side you can take care of this and I can help you if you need help. What do you think?

@dondaum
Copy link
Contributor

dondaum commented Oct 9, 2024

@potiuk can you please assign @michaeljs-c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API contributors-workshop Issues that are good for first-time contributor's workshop good first issue kind:feature Feature Requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants