Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra metrics are being sent to DataDog when using Allow list with pattern matching enabled #39400

Open
2 tasks done
rawwar opened this issue May 4, 2024 · 0 comments
Open
2 tasks done
Assignees
Labels
affected_version:main_branch Issues Reported for main branch area:core area:metrics kind:bug This is a clearly a bug

Comments

@rawwar
Copy link
Collaborator

rawwar commented May 4, 2024

Apache Airflow version

main (development)

If "Other Airflow 2 version" selected, which one?

No response

What happened?

with AIRFLOW__METRICS__METRICS_USE_PATTERN_MATCH set to true and AIRFLOW__METRICS__METRICS_ALLOW_LIST set to .*get_astronauts.* , I notice several other metrics being sent to datadog that don't match the pattern:
image

What you think should happen instead?

Following metrics shouldn't be showing up on datadog when the allow list is .*get_astronauts.*:

  1. airflow.dag.task.duration.*
  2. airflow.ti.*
  3. datadog.* (Not sure if we have any control to block these)

How to reproduce

env variables:

AIRFLOW__METRICS__STATSD_DATADOG_ENABLED true
AIRFLOW__METRICS__STATSD_DATADOG_TAGS testNo:C2
DATADOG_API_KEY ● ● ● ● ● ● ●
AIRFLOW__METRICS__METRICS_USE_PATTERN_MATCH true
AIRFLOW__METRICS__METRICS_ALLOW_LIST .*print_astronaut_craft.*

Once you update your datadog key here, you will start seeing metrics in datadog-->metrics-->summary . use the tag testNo:C2 to filter

Operating System

Debian GNU/Linux 11 (bullseye)

Versions of Apache Airflow Providers

No response

Deployment

Astronomer

Deployment details

No response

Anything else?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@rawwar rawwar added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels May 4, 2024
@rawwar rawwar self-assigned this May 5, 2024
@rawwar rawwar added area:metrics and removed needs-triage label for new issues that we didn't triage yet labels May 7, 2024
@eladkal eladkal added the affected_version:main_branch Issues Reported for main branch label Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected_version:main_branch Issues Reported for main branch area:core area:metrics kind:bug This is a clearly a bug
Projects
None yet
Development

No branches or pull requests

2 participants