Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Provder Operators and Sensors Duplicate Code #36386

Closed
1 of 2 tasks
dirrao opened this issue Dec 23, 2023 · 3 comments
Closed
1 of 2 tasks

AWS Provder Operators and Sensors Duplicate Code #36386

dirrao opened this issue Dec 23, 2023 · 3 comments
Labels
area:providers kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet pending-response provider:amazon AWS/Amazon - related issues

Comments

@dirrao
Copy link
Contributor

dirrao commented Dec 23, 2023

Apache Airflow Provider(s)

amazon

Versions of Apache Airflow Providers

apache-airflow-providers-amazon 8.13.0

Apache Airflow version

2.8.0

Operating System

Cent OS 7

Deployment

Other

Deployment details

Docker based deployments

What happened

I have seen duplicate code related to deferrable execute_complete in operators and sensors of aws provider. It would be nice to abstract this into aws base operator/sensor and inherit it across all the aws operators and sensors to avoid duplicate code.

What you think should happen instead

It would be nice to abstract this into aws base operator/sensor and inherit it across all the aws operators and sensors to avoid duplicate code.

How to reproduce

N/A

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@dirrao dirrao added area:providers kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Dec 23, 2023
@Taragolis
Copy link
Contributor

Is it some how related to the #35278 ?

@Taragolis Taragolis added provider:amazon AWS/Amazon - related issues kind:feature Feature Requests pending-response and removed kind:bug This is a clearly a bug labels Dec 23, 2023
@dirrao
Copy link
Contributor Author

dirrao commented Dec 24, 2023

Is it some how related to the #35278 ?

Yes. Both of them meant for the same.

@Taragolis
Copy link
Contributor

Ok, let's then close this one in favor or #35278.
If required something more than described in #35278 then required to add more details and we could reopen this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:providers kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet pending-response provider:amazon AWS/Amazon - related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Taragolis @dirrao