-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the Snowflake Python Connector to version 2.7.8 or later #34748
Comments
Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval. |
Maybe we can create a PR with the version updated and see how it works with the CI and how the community reacts to it 🙂 |
We allow any version of If I use snowflake as is without gcp why should I be forced to use |
Although version 2.7.8 is for GCP, but it is still very old. The requirements in the repo mention unsupported versions (2.4.1 / 1.0.0) . The versions need an update either way to keep up with the versions supported by Snowflake. Please find below from the requirements page https://docs.snowflake.com/en/release-notes/requirements Snowflake Connector for Python
Snowflake SQLAlchemy (for Python)
|
But we are not limiting the users.. they can choose what they like. We do our best to support all possible versions. We let the users to decide what to use. I am fine with bumping versions if there is good reason (old is not a reason) because old versions can still work. If you'll take a look at the other dependencies we have you will see for example we bumped many Azure packages lately but that is because we had to do it to include new features that are part of the Azure integration to Airflow itself (hooks, operators). Maybe @potiuk have different view on this? |
I think I agree with you @eladkal that we should be careful, but also I think bumping to 2.7.8 should be quite fine here. Those two are not conflicting IMHO in this case. Currently the "golden" set of constraints we have - 3.2.1 / 1.5.0, so it will be generally "no-op" to bump the min versions to any higher version lower than that (from the maintenance point of view). For many smaller providers, we can just use very "recent" versions as min versions. When those providers have very few dependencies on their own. But Snowflake provider is different - the connector has 21 dependencies - many of them limited and many of them shared with other libraries. So bumping min version might cause the potential conflicts that @eladkal described (it already has in the past). One note worth mentioning though. We should be just a "little" careful, that it will only happen when someone actually installs snowflake provider. It does not limit "airlfow core" package, so it is highly likely that users who install snowflake provider will not want to run old, unsupported snowflake connector anyway. Also those who want to do it regardless, can still install previous provider. I guess you assesed Airflow as important driver for your adoption - and we absolutely welcome involvement of the stakeholders in our providers in being more active in maintaining them, so I hope this might be a beggining of such cooperation. Happy to review and help to get it merged - will you do it @sfc-gh-rjoshi ? |
@sfc-gh-rjoshi ? How about implementing it ? |
Description
As per the change made by Snowflake (affecting customers on GCP), kindly update the 'Snowflake' Python Connector version to version 2.7.8 or later.
Please note all recent versions of Snowflake SQL-alchemy connector have support for this change as they use the Python Connector more recent than above.
Here is the complete information on the change reasons and recommendations - https://community.snowflake.com/s/article/faq-2023-client-driver-deprecation-for-GCP-customers
Use case/motivation
If this change is not made Airflow customers on GCP will not be able to perform PUT operations to their Snowflake account.
Soft Cutover enforced by Snowflake is Oct 30, 2023.
Hard Cutover enforced by Google is Jan 15, 2024
https://community.snowflake.com/s/article/faq-2023-client-driver-deprecation-for-GCP-customers
Related issues
https://community.snowflake.com/s/article/faq-2023-client-driver-deprecation-for-GCP-customers
Are you willing to submit a PR?
Code of Conduct
The text was updated successfully, but these errors were encountered: