Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image of xcom_sidecar is not configurable #32805

Closed
1 of 2 tasks
raycarter opened this issue Jul 24, 2023 · 4 comments
Closed
1 of 2 tasks

Docker image of xcom_sidecar is not configurable #32805

raycarter opened this issue Jul 24, 2023 · 4 comments
Assignees
Labels
area:providers good first issue kind:bug This is a clearly a bug provider:cncf-kubernetes Kubernetes provider related issues

Comments

@raycarter
Copy link

Description

The iamge of xcom_sidecar is not cunfigurable (code: xcom_sidecar.py#36). In our situation we can not access the "alpine" image from the docker image registry. Then the pod will not be started because the pulling of image failed.

Therefore it would be very nice that the image of xcom_sidecar is configurable so that we can pass an image hosted by our registry.

I see there was a merged PR about this feature #26766. But the changes was deleted in the commit a1f5a54.

Could you please review it and add this feature again? Thanks!

Use case/motivation

Usecase:

Use KubernetesPodOperator with do_xcom_push=True in an environment which can not access docker image registry.

Related issues

PR #26766 deleted in a1f5a54

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@raycarter raycarter added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Jul 24, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 24, 2023

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@jscheffl jscheffl added good first issue provider:kubernetes type:improvement Changelog: Improvements and removed needs-triage label for new issues that we didn't triage yet kind:feature Feature Requests labels Jul 24, 2023
@jscheffl
Copy link
Contributor

Thanks for filing this request. I can understand for private hosted environment the access to public docker registry might be limited. Had been myself in the same situation.
@dstandish Do you know why this feature was removed? Had there been an intend to this?

@pegasas
Copy link
Contributor

pegasas commented Jul 25, 2023

hi, @jens-scheffler-bosch , I am freshman in airflow community and willing to contribute, will you like to assign this task to me as me good first issue?

@eladkal eladkal added provider:cncf-kubernetes Kubernetes provider related issues area:providers kind:bug This is a clearly a bug and removed provider:kubernetes type:improvement Changelog: Improvements labels Jul 29, 2023
@eladkal
Copy link
Contributor

eladkal commented Aug 5, 2023

Solved in #32858

@eladkal eladkal closed this as completed Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers good first issue kind:bug This is a clearly a bug provider:cncf-kubernetes Kubernetes provider related issues
Projects
None yet
Development

No branches or pull requests

4 participants