Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Ads API Sunset for Version 11 #30353

Closed
1 of 2 tasks
cgadam opened this issue Mar 29, 2023 · 2 comments
Closed
1 of 2 tasks

Google Ads API Sunset for Version 11 #30353

cgadam opened this issue Mar 29, 2023 · 2 comments
Labels
area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet

Comments

@cgadam
Copy link

cgadam commented Mar 29, 2023

Apache Airflow version

2.5.2

What happened

Current version of Airflow (2.5.2) has as constraint google ads version 18.0.0, see here.

Now, version 18.0.0 has support only for version 11 of the API. See here for release notes of version 18.0.0. Actually the last support for API version was added here for version 11 (v17.0.0)

Version 11 sunset is today (March 29, 2023) which means, starting today API calls done to the API should start failing. See deprecation and sunset days here: https://developers.google.com/google-ads/api/docs/sunset-dates

Long story short, current latest version of Airflow doesn't supports (as part of its constraints file) any actual working version of google-ads.

Not sure how you come up with which versions are meant to be listed in the constraints file, but, v12 which is the next version of google-ads that is still active was added as supported by google-ads in version 18.2.0. See here

Not sure how you test which versions are safe to put in the constraints file, but it seems that it would be worth updating at least to google-ads 18.2.0 to support a pypi package that can actually interact with Google Ads API.

What you think should happen instead

No response

How to reproduce

Just all calls to Google Ads API should start failing when using google-ads version 18 as sunset for v11 which is the max API version supported by that version of the package is sunsetting

Operating System

Any

Versions of Apache Airflow Providers

No response

Deployment

Other

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@cgadam cgadam added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Mar 29, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 29, 2023

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@potiuk
Copy link
Member

potiuk commented Mar 29, 2023

google team is working on it in #30067

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet
Projects
None yet
Development

No branches or pull requests

2 participants