Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taskgroups show incorrect status in grid view #24998

Closed
1 of 2 tasks
pascal-knapen opened this issue Jul 12, 2022 · 5 comments
Closed
1 of 2 tasks

Taskgroups show incorrect status in grid view #24998

pascal-knapen opened this issue Jul 12, 2022 · 5 comments
Labels
affected_version:2.3 Issues Reported for 2.3 area:UI Related to UI/UX. For Frontend Developers. kind:bug This is a clearly a bug

Comments

@pascal-knapen
Copy link

Apache Airflow version

2.3.2

What happened

Once a task belonging to a TaskGroup is in the status failed or upstream failed, that status is shown for the TaskGroup over all the runs in grid view.

What you think should happen instead

I expect in the grid view to see TaskGroups in the status corresponding to the status of the tasks in that group for the given dag run.

How to reproduce

  1. Create a DAG using taskgroups
from airflow import DAG
from airflow.utils.task_group import TaskGroup
from airflow.operators.empty import EmptyOperator
from datetime import datetime, timedelta


default_args = {
    "depends_on_past": False,
    "start_date": datetime(year=2022, month=7, day=9),
    "email": [],
    "email_on_failure": False,
    "email_on_retry": False,
    "retries": 0,
    "retry_delay": timedelta(minutes=5),
}

with DAG(
    "sample-taskgroup", default_args=default_args, schedule_interval="@daily", max_active_runs=1
) as dag: 

    t0 = EmptyOperator(task_id='start')

    # Start Task Group definition
    with TaskGroup(group_id='group1') as tg1:
        t1 = EmptyOperator(task_id='task1')
        t2 = EmptyOperator(task_id='task2')

        t1 >> t2
    # End Task Group definition
        
    t3 = EmptyOperator(task_id='end')

    # Set Task Group's (tg1) dependencies
    t0 >> tg1 >> t3
  1. Change the status of one of the tasks in the taskgroup
airflow_taskgroup_status.mov

Operating System

Debian GNU/Linux 11 (bullseye)

Versions of Apache Airflow Providers

N/A

Deployment

Other Docker-based deployment

Deployment details

N/A

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@pascal-knapen pascal-knapen added area:core kind:bug This is a clearly a bug labels Jul 12, 2022
@boring-cyborg
Copy link

boring-cyborg bot commented Jul 12, 2022

Thanks for opening your first issue here! Be sure to follow the issue template!

@potiuk
Copy link
Member

potiuk commented Jul 12, 2022

I love the video-report :)

@uranusjr uranusjr added area:UI Related to UI/UX. For Frontend Developers. and removed area:core labels Jul 13, 2022
@josh-fell josh-fell added the affected_version:2.3 Issues Reported for 2.3 label Jul 13, 2022
@josh-fell
Copy link
Contributor

@pascal-knapen Thanks for submitting this issue. Definitely not the desired behavior. Can you check out Airflow 2.3.3 and see if the issue is fixed when you get a chance please? I did a quick test with the example you provided on 2.3.3 as well as the main branch and this seems to be fixed.

@bbovenzi
Copy link
Contributor

This was fixed in #24327 which was included in 2.3.3

@pascal-knapen
Copy link
Author

Thanks @bbovenzi for checking, that saved me some time this evening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affected_version:2.3 Issues Reported for 2.3 area:UI Related to UI/UX. For Frontend Developers. kind:bug This is a clearly a bug
Projects
None yet
Development

No branches or pull requests

5 participants