Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breeze: Exec'ing into running Breeze #21104

Closed
potiuk opened this issue Jan 25, 2022 · 4 comments · Fixed by #23052
Closed

Breeze: Exec'ing into running Breeze #21104

potiuk opened this issue Jan 25, 2022 · 4 comments · Fixed by #23052
Assignees
Labels
area:dev-env-Breeze2 Breeze 2 issues kind:task A task that needs to be completed as part of a larger issue

Comments

@potiuk
Copy link
Member

potiuk commented Jan 25, 2022

./Breeze2 exec should exec into the currently running Breeze (or fail with helpful message if Breeze is not running).

@eladkal eladkal added kind:task A task that needs to be completed as part of a larger issue area:dev-env-Breeze2 Breeze 2 issues labels Feb 28, 2022
@Bowrna
Copy link
Contributor

Bowrna commented Apr 7, 2022

@potiuk Shall I pick up this task? :)

@potiuk
Copy link
Member Author

potiuk commented Apr 7, 2022

Please :)

@Bowrna
Copy link
Contributor

Bowrna commented Apr 9, 2022

@potiuk DOCKER_COMPOSE_RUN_SCRIPT_FOR_PROD i see this variable is not set anywhere. Can you tell me about this?

airflow/breeze

Lines 3480 to 3485 in 95a1b71

if [[ ${PRODUCTION_IMAGE} == "true" ]]; then
dc_run_file="${BUILD_CACHE_DIR}/${DOCKER_COMPOSE_RUN_SCRIPT_FOR_PROD}"
else
dc_run_file="${BUILD_CACHE_DIR}/${DOCKER_COMPOSE_RUN_SCRIPT_FOR_CI}"
fi

@potiuk
Copy link
Member Author

potiuk commented Apr 13, 2022

@potiuk DOCKER_COMPOSE_RUN_SCRIPT_FOR_PROD i see this variable is not set anywhere. Can you tell me about this?

airflow/breeze

Lines 3480 to 3485 in 95a1b71

if [[ ${PRODUCTION_IMAGE} == "true" ]]; then
dc_run_file="${BUILD_CACHE_DIR}/${DOCKER_COMPOSE_RUN_SCRIPT_FOR_PROD}"
else
dc_run_file="${BUILD_CACHE_DIR}/${DOCKER_COMPOSE_RUN_SCRIPT_FOR_CI}"
fi

It's just an artifact of very old way when we could exec and run into prod image as well. This should be gone :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-env-Breeze2 Breeze 2 issues kind:task A task that needs to be completed as part of a larger issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants