You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The metric scheduler.tasks.running is populated from the variable num_tasks_in_executor in scheduler_job.py. However, num_tasks_in_executor is initialized to 0 and then never updated again.
However, I'm not sure if this is the best course of action because we don't know if the tasks is successfully added until the the list of executable TIs is returned within _critical_section_execute_task_instances, and those TIs are attempted to be queued in _enqueue_task_instances_with_queued_state.
I believe we could close this out as we removed that metrics #30374. You should be using executor running and executor queued task metrics. cc: @vincbeck
Apache Airflow version
2.2.3 (latest released)
What happened
The metric
scheduler.tasks.running
is populated from the variablenum_tasks_in_executor
in scheduler_job.py. However,num_tasks_in_executor
is initialized to0
and then never updated again.Function
_executable_task_instances_to_queued
:airflow/airflow/jobs/scheduler_job.py
Line 328 in c59001d
airflow/airflow/jobs/scheduler_job.py
Line 457 in c59001d
I considered just opening a PR modifying that value with the rest of these "counter" modifications:
airflow/airflow/jobs/scheduler_job.py
Lines 449 to 452 in c59001d
However, I'm not sure if this is the best course of action because we don't know if the tasks is successfully added until the the list of executable TIs is returned within
_critical_section_execute_task_instances
, and those TIs are attempted to be queued in_enqueue_task_instances_with_queued_state
.airflow/airflow/jobs/scheduler_job.py
Lines 534 to 540 in c59001d
airflow/airflow/executors/base_executor.py
Lines 73 to 85 in c59001d
What you expected to happen
No response
How to reproduce
No response
Operating System
Ubuntu 19.10
Versions of Apache Airflow Providers
No response
Deployment
Other Docker-based deployment
Deployment details
No response
Anything else
No response
Are you willing to submit PR?
Code of Conduct
The text was updated successfully, but these errors were encountered: