Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hour and minute to time format on x-axis in Landing Times #19955

Closed
2 tasks done
hwooson12 opened this issue Dec 2, 2021 · 3 comments · Fixed by #20002
Closed
2 tasks done

Add hour and minute to time format on x-axis in Landing Times #19955

hwooson12 opened this issue Dec 2, 2021 · 3 comments · Fixed by #20002
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests

Comments

@hwooson12
Copy link
Contributor

hwooson12 commented Dec 2, 2021

Description

It would be great if the date and time format of x-axis in Landing Times is %d %b %Y, %H:%M instead of %d %b %Y to see execution_date of task instances.

Use case/motivation

For x-axis of all line chart using nvd3.lineChart, the date and time format has only date without time because its format is %d %b %Y by default when x_is_date is True. From what I have seen in version 1.7, the date and time format was like %d %b %Y, %H:%M. It has been changed as Highcharts was no longer used since version 1.8. It is simple to fix by injecting x_axis_format="%d %b %Y, %H:%M" where every nvd3.lineChart class is initialized.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@hwooson12 hwooson12 added the kind:feature Feature Requests label Dec 2, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 2, 2021

Thanks for opening your first issue here! Be sure to follow the issue template!

@uranusjr uranusjr added the area:UI Related to UI/UX. For Frontend Developers. label Dec 2, 2021
@bbovenzi
Copy link
Contributor

bbovenzi commented Dec 2, 2021

Makes sense to me! Let me know if you need help getting the PR ready.

@hwooson12
Copy link
Contributor Author

@bbovenzi I created a PR. But I am new to create a PR here so that the PR needs maintainer's approval to run workflows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. kind:feature Feature Requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants