Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate execution_date database columns to logical_date #19049

Closed
uranusjr opened this issue Oct 18, 2021 · 6 comments
Closed

Migrate execution_date database columns to logical_date #19049

uranusjr opened this issue Oct 18, 2021 · 6 comments
Assignees
Labels
AIP-39 Timetables AIP-83 Remove Execution Date Unique Constraint from DAG Run
Milestone

Comments

@uranusjr
Copy link
Member

To conform with other AIP-39 changes. execution_date should still be kept on the class and emit a deprecation warning when accessed (either as a property or a filter). I think there's mechanism in SQLAlchemy for this out of the box.

@uranusjr uranusjr added the AIP-39 Timetables label Oct 18, 2021
@uranusjr uranusjr added this to the Airflow 2.3.0 milestone Oct 18, 2021
@uranusjr uranusjr self-assigned this Oct 18, 2021
@kaxil
Copy link
Member

kaxil commented Mar 16, 2022

Is this still pending @uranusjr ?

@uranusjr
Copy link
Member Author

uranusjr commented Apr 6, 2022

Let's not do this in 2.3

@uranusjr uranusjr removed this from the Airflow 2.3.0 milestone Apr 6, 2022
@eladkal
Copy link
Contributor

eladkal commented Sep 19, 2024

@uranusjr should we add this task also under AIP-83 project effort?

@uranusjr
Copy link
Member Author

uranusjr commented Sep 20, 2024

Ah I totally forgot this issue exists. Thanks, going to add it. The database level migration is already done, but we still need to rename the attribute on the model (and all references to it, obviously). We also don’t need to emit a deprecation warning since this is only for 3.0.

@uranusjr uranusjr added the AIP-83 Remove Execution Date Unique Constraint from DAG Run label Sep 20, 2024
@uranusjr uranusjr added this to the Airflow 3.0.0 milestone Sep 20, 2024
@phanikumv phanikumv moved this from Backlog to In progress in AIP-83 Remove execution date Nov 15, 2024
@phanikumv
Copy link
Contributor

This is covered in #43902

@github-project-automation github-project-automation bot moved this from In progress to Done in AIP-83 Remove execution date Nov 15, 2024
@sunank200
Copy link
Collaborator

Now that this PR: #43902 is merged following is covered:

The database level migration is already done, but we still need to rename the attribute on the model (and all references to it, obviously). We also don’t need to emit a deprecation warning since this is only for 3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AIP-39 Timetables AIP-83 Remove Execution Date Unique Constraint from DAG Run
Projects
Status: Done
Development

No branches or pull requests

5 participants