-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SambaHook using old unmaintained library #14054
Comments
Hi...May I work on this ? |
Sure! I assigned you :) |
@potiuk thanks man ;) |
thanks @Rishabhraghwendra18 looking forward to this! |
I am really sorry guys. I am not able to setup the development on my machine . And I am also having university exams within this month .So I am not able to contribute 😞. I am unassingning myself. |
Too bad. Next time maybe, |
ya..sure |
@potiuk can I take this one instead? I'm finishing the Airbyte provider so right now is easier to do this modification :D |
@marcosmarxm Sure, all yours! |
It seems like pysmb is another choice. Not sure whether it or smbprotocol is better/more suitable. |
@uranusjr one deficiency in I might be able to find time to dig into this – adding "credits support". If there's a reference implementation in Go, then it shouldn't be too hard. |
Description
The SambaHook currently using pysmbclient this library hasn't been updated since 2017 https://pypi.org/project/PySmbClient/
I think worth moving to https://pypi.org/project/smbprotocol/ which newer and maintained.
The text was updated successfully, but these errors were encountered: