Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite our Github Action workflows to Python #13182

Closed
potiuk opened this issue Dec 19, 2020 · 9 comments
Closed

Rewrite our Github Action workflows to Python #13182

potiuk opened this issue Dec 19, 2020 · 9 comments
Labels
area:CI Airflow's tests and continious integration kind:feature Feature Requests

Comments

@potiuk
Copy link
Member

potiuk commented Dec 19, 2020

Yesterday (18th of December) GitHub announced a 3rd-party Python GHApi: https://github.blog/2020-12-18-learn-about-ghapi-a-new-third-party-python-client-for-the-github-api/

One of the features of the API is the ability to write GitHub Actions Workflows (including custom actions) entirely in Python:

https://github.blog/2020-12-18-learn-about-ghapi-a-new-third-party-python-client-for-the-github-api/#github-actions

This is super cool. Knowing the difficulties of combining YAML files, bash scripts and TypeScripts Actions) together, this is a so much better and easier way of writing the workflows,

We should rewrite all our workflows using this new API !

@potiuk potiuk added the kind:feature Feature Requests label Dec 19, 2020
@potiuk
Copy link
Member Author

potiuk commented Dec 19, 2020

cc: @kaxil @ashb @turbaszek @mik-laj and @TobKed - let's do it!

@potiuk potiuk changed the title Rwwrite our Github Action workflows to Python Rewrite our Github Action workflows to Python Dec 19, 2020
@kaxil
Copy link
Member

kaxil commented Dec 21, 2020

🎉 Yes let's do it

@vikramkoka vikramkoka added the area:CI Airflow's tests and continious integration label May 4, 2021
@emmanue
Copy link

emmanue commented Nov 28, 2021

@potiuk I will like to help and contribute.

@TobKed
Copy link
Contributor

TobKed commented Nov 28, 2021

@potiuk is it sill something considered to be done?

@eladkal
Copy link
Contributor

eladkal commented Nov 28, 2021

@potiuk is it sill something considered to be done?

This is in fact in progress. We have an intern from the Outreachy project that will take over this.

@potiuk
Copy link
Member Author

potiuk commented Nov 28, 2021

Oh yeah. I will update the issue soon with an inventory of what is needed and we will work from here. Similarly #12282 with rewriting breeze. Those will have some overlap so the two interns will be working together. More on that soon!

@potiuk
Copy link
Member Author

potiuk commented Nov 28, 2021

Yeah. Finally the time had come to start work on the rewrite:

First, founding PR is here: #19867 - those who are interested will find there some ADR (Architecture Decision Records) which we will keep throughout the whole project to capture all important decisions we've made and once we merge it, more stuff will come.

@eladkal
Copy link
Contributor

eladkal commented Feb 12, 2023

I believe this is now completed :) ?

@potiuk
Copy link
Member Author

potiuk commented Feb 12, 2023

Oh. Vrery much so :).

@potiuk potiuk closed this as completed Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CI Airflow's tests and continious integration kind:feature Feature Requests
Projects
None yet
Development

No branches or pull requests

6 participants