-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ORC support to GCSToBigQueryOperator #12556
Comments
Thanks for opening your first issue here! Be sure to follow the issue template! |
As mentioned in PR the |
@juneoh Are you willing to submit a PR? |
Sure, I'll take a look during the holidays. |
I've learned that holiday productivity is an illusion. I'll check in again next week as I'm ramping back up. |
Still working on this. The basic implementation is done but it's mostly a copy-paste from the BigQuery hook, so I'm trying to see what additional refactoring and testing is possible with the leverage of BigQuery Python SDK. |
@juneoh are you still working on it? |
The fix needed (while small) is in a deprecated function of the hook. I'm closing this issue as won't fix |
Hi @eladkal, I would love to take this issue up - I just faced this issue at work where we store all our data in ORC. I read the comments, briefly and understand that initially, the suggestions were to put the fix in a function/hook that is now deprecated. What would be the approach to adding this feature today? Would you be able to point to the file/function in Airflow I should be making this change? Seems like we will need to provide some of the same logical type mapping that is supported with AVRO as well: https://cloud.google.com/bigquery/docs/loading-data-cloud-storage-orc#orc_conversions. |
Description
BigQuery API for loading data lists ORC file format as one of the supported formats, but it is currently not allowed in GCSToBigQueryOperator. Specifying ORC as the source format raises a ValueError in BigQueryHook.
Use case / motivation
Include ORC file format in BigQueryHook so that GCSToBigQueryOperator will fully allow all file formats supported by the BigQuery API.
The text was updated successfully, but these errors were encountered: