Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing system tests for Qubole provider #10931

Closed
mik-laj opened this issue Sep 14, 2020 · 3 comments
Closed

Missing system tests for Qubole provider #10931

mik-laj opened this issue Sep 14, 2020 · 3 comments
Labels
area:providers good first issue kind:task A task that needs to be completed as part of a larger issue

Comments

@mik-laj
Copy link
Member

mik-laj commented Sep 14, 2020

Hello,

We are trying to work on increasing system test coverage of all providers that require credentials to communicate with external services/systems. Currently, system tests are not run on CI, but are still very helpful if you make changes to your code and want to make sure no regression has occurred. In the future, we want to run these tests also on CI - AIP-4.

I noticed that we lack system tests for Qubole and I think it is worth adding these tests to make sure that the example DAG and documentation do not have defects.

Best regards,
Kamil Bregułaa

@mik-laj mik-laj added the kind:feature Feature Requests label Sep 14, 2020
@mik-laj
Copy link
Member Author

mik-laj commented Sep 14, 2020

@chattarajoy Can you look at it?

@chattarajoy
Copy link
Contributor

Sure @mik-laj , we can definitely add a few system tests. Please assign it to me

@chattarajoy chattarajoy removed their assignment Jan 15, 2021
@eladkal eladkal added kind:task A task that needs to be completed as part of a larger issue and removed kind:feature Feature Requests labels Feb 15, 2021
@eladkal
Copy link
Contributor

eladkal commented Apr 21, 2022

Closing in favor of #22460

@eladkal eladkal closed this as completed Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers good first issue kind:task A task that needs to be completed as part of a larger issue
Projects
None yet
Development

No branches or pull requests

4 participants