Skip to content

Commit

Permalink
Validate executor and config.core.executor match (#30693)
Browse files Browse the repository at this point in the history
The chart expects the executor to be set in `executor`, however if a
user only sets `config.core.executor` it is difficult to diagnose as the
chart deploys the wrong rbac resources. This tries to catch that
situation.
  • Loading branch information
jedcunningham authored Apr 22, 2023
1 parent 3f5280b commit 8cfc0f6
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions chart/templates/NOTES.txt
Original file line number Diff line number Diff line change
Expand Up @@ -193,3 +193,7 @@ https://airflow.apache.org/docs/helm-chart/stable/production-guide.html#webserve
{{ fail "postgresql.postgresqlUsername and postgresql.postgresqlPassword are no longer supported. If you wish to use the 'postgres' user, set its password with postgresql.auth.postgresPassword. If you wish to create a different user, do so with postgresql.auth.username and postgresql.auth.password." }}

{{- end }}

{{- if ne .Values.executor (tpl .Values.config.core.executor $) }}
{{ fail "Please configure the executor with `executor`, not `config.core.executor`." }}
{{- end }}

0 comments on commit 8cfc0f6

Please sign in to comment.