From 4f1e66d0227fba7a1378e895b9186711c03ead61 Mon Sep 17 00:00:00 2001 From: Ash Berlin-Taylor Date: Fri, 12 Nov 2021 12:41:52 +0000 Subject: [PATCH] Upload KinD logs on cancell too (#19554) If the job times out, it is "cancelled", rather than failed, which means that the logs were not uploaded. This will likely also catch a few cases where the job is cancelled cos of another push to the branch/PR, but it's better to have too many logs than not enough to debug problems --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 56dc06674ab21..4e73b88957adf 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -1056,7 +1056,7 @@ ${{ hashFiles('.pre-commit-config.yaml') }}" PR_LABELS: "${{ needs.build-info.outputs.pullRequestLabels }}" - name: "Upload KinD logs" uses: actions/upload-artifact@v2 - if: failure() + if: failure() || cancelled() with: name: > kind-logs-${{matrix.executor}} @@ -1124,7 +1124,7 @@ ${{ hashFiles('.pre-commit-config.yaml') }}" PR_LABELS: "${{ needs.build-info.outputs.pullRequestLabels }}" - name: "Upload KinD logs" uses: actions/upload-artifact@v2 - if: failure() + if: failure() || cancelled() with: name: > kind-logs-KubernetesExecutor