Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

refactor(SupersetClient): use new /api/v1/security/csrf_token/ endpoint #980

Merged
merged 2 commits into from
Mar 1, 2021

Conversation

nytai
Copy link
Contributor

@nytai nytai commented Feb 26, 2021

corresponding SupersetClient change for: apache/superset#13212

@vercel
Copy link

vercel bot commented Feb 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/FRAwQp6Fi14NX1hS5GtWVbFrUv1u
✅ Preview: https://superset-ui-git-fork-preset-io-tai-new-csrf-endpoint-superset.vercel.app

@nytai nytai force-pushed the tai/new-csrf-endpoint branch from 7ee2fa6 to c7eb706 Compare February 26, 2021 22:36
@nytai nytai changed the title fix(SupersetClient): use new /api/v1/security/csrf_token/ endpoint refactor(SupersetClient): use new /api/v1/security/csrf_token/ endpoint Feb 26, 2021
@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #980 (c7eb706) into master (e7a7f88) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #980   +/-   ##
=======================================
  Coverage   28.05%   28.05%           
=======================================
  Files         409      409           
  Lines        8363     8363           
  Branches     1173     1173           
=======================================
  Hits         2346     2346           
  Misses       5868     5868           
  Partials      149      149           
Impacted Files Coverage Δ
...rset-ui-core/src/connection/SupersetClientClass.ts 100.00% <100.00%> (ø)
.../superset-ui-core/test/chart/fixtures/constants.ts 100.00% <100.00%> (ø)
...rset-ui-core/test/connection/fixtures/constants.ts 100.00% <100.00%> (ø)
...erset-ui-core/test/query/api/setupClientForTest.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7a7f88...c7eb706. Read the comment docs.

@nytai nytai marked this pull request as ready for review March 1, 2021 18:24
@nytai nytai requested a review from a team as a code owner March 1, 2021 18:24
Copy link
Contributor

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nytai nytai merged commit 0b48c32 into apache-superset:master Mar 1, 2021
@nytai nytai deleted the tai/new-csrf-endpoint branch March 1, 2021 21:46
NejcZdovc pushed a commit to blotoutio/superset-ui that referenced this pull request Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants