This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
feat: make formatTime and formatNumber accept undefined type #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 103 103
Lines 1223 1223
Branches 300 300
=====================================
Hits 1223 1223
Continue to review full report at Codecov.
|
ktmud
reviewed
Mar 4, 2020
| @@ -43,5 +43,8 @@ describe('NumberFormatterRegistry', () => { | |||
| expect(registry.format('.2f', 100)).toEqual('100.00'); | |||
| expect(registry.format(',d', 100)).toEqual('100'); | |||
| }); | |||
| it('falls back to the default formatter if the format is undefined', () => { | |||
| expect(registry.format(undefined, 1000)).toEqual('1k'); | |||
| }); | |||
There was a problem hiding this comment.
Thanks for adding the test case!
|
Deploy preview for superset-ui ready! Built with commit f939a37 |
|
Actually, this file needs to be updated, too: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
formatTimeandformatNumberhandleundefinedtype. The logic is already there, but the argument type was stillstringcc @ktmud