[monorepo] add travis + codecov ✅ #2
Conversation
package.json
Outdated
| @@ -27,6 +27,7 @@ | |||
| ], | |||
| "license": "Apache-2.0", | |||
| "devDependencies": { | |||
| "coveralls": "^3.0.2", | |||
There was a problem hiding this comment.
Can we use Codecov instead of Coveralls? This ensures consistency with incubator-superset and doesn’t require a token.
There was a problem hiding this comment.
yes, I initially tried codecov and couldn't add it to this repo so tried coveralls ... still can't add it to the repo so I'll move back to coveralls 👍
There was a problem hiding this comment.
So the after-script command fails,
$ ./node_modules/.bin/codecov
/home/travis/.travis/job_stages: line 78: ./node_modules/.bin/codecov: No such file or directory
.travis.yml
Outdated
| fast_finish: true | ||
|
|
||
| install: | ||
| - npm install && lerna bootstrap |
There was a problem hiding this comment.
I believe you can list each command seperately.
williaster
force-pushed
the
chris--coverage
branch
from
6481dfb to
dcb8ac2
Compare
|
things are all getting executed correctly, trying to debug why coverage %s are being reported as unknown. |
Codecov Report
@@ Coverage Diff @@
## chris--core-package #2 +/- ##
======================================================
Coverage ? 98.46%
======================================================
Files ? 7
Lines ? 65
Branches ? 0
======================================================
Hits ? 64
Misses ? 1
Partials ? 0Continue to review full report at Codecov.
|
|
It only took 16 commits but 🎉 (there was an issue with |
.travis.yml
Outdated
| @@ -20,4 +21,4 @@ script: | |||
| - 'cd ./packages/$PACKAGE && yarn install && yarn run lint && yarn run test' | |||
|
|
|||
| after_script: | |||
| - './node_modules/codecov/bin/codecov' | |||
| - 'codecov' | |||
There was a problem hiding this comment.
@john-bodley for all scripts?
.travis.yml
Outdated
| - PACKAGE=superset-ui-core | ||
|
|
||
| script: | ||
| - cd ./packages/$PACKAGE && yarn install && yarn run lint && yarn run test |
There was a problem hiding this comment.
You can split the script to br a series of commands,
script:
- cd ./packages/$PACKAGE
- yarn install
- ...
There was a problem hiding this comment.
that's prob nicer for debugging too 👍
.travis.yml
Outdated
| language: node_js | ||
|
|
||
| node_js: | ||
| - '10.7' |
There was a problem hiding this comment.
Nix the quotes here too.
|
gonna merge this into the wrong branch to get a cherry pickable hash for master. don't think I can change the branch I'm merging into now and the other is merged. |
* [monorepo] initial attempt at travis * [monorepo] coveralls => codecov * [monorepo] don't lerna bootstrap? * [monorepo] ignore lock files, add lint:fix script * [core] add node-fetch dev dep * [monorepo] tweak codecov call * [monorepo] tweak codecov call take ii * [monorepo] codecov again * [core][deps] build-config@^0.0.11 * [core][jest] add <rootDir> to coveragePathIgnorePatterns paths * [core][jest] add collectCoverageFrom config * [core][jest] try adding rootDir to collectCoverageFrom glob * [core][deps] [email protected] * [travis] yolo * [travis] this is the one * [travis] install global codecov * [travis] no quotes in yml * [travis] no quotes in yml part 2
kristw
added
reviewable
* [build] fix typescript builds * [typescript] ensure types pass in build * [typescript][connection] declare modules in tests * [typescript][connection] fix ts errors in tests * [typescript][connection] test/types.ts => types/external.d.ts * [chart][typescript] add @types/react-loadable * [chart][components] convert to ts * [charts][tests][broken] convert to ts * [chart][typescript] re-write component generics * [chart][typescript] fix reactify generic, add react-dom types * [chart][typescript] more iteration * - Tweaking reactify types (using Readonly types). - Uncovered an issue in which ReactifyProps and Props can collide on id and className. - Move @types/react-loadable to dev dependency - Fixing a lint error * [chart][deps] add @types/fetch-mock * [client][typescript] add and export SupersetClientInterface * [chart][clients] fix ts * [charts][components] more ts iterations * [chart][client] assert FormData type * [chart][deps] try adding newest @types/react * [chart][components][ts] fix reactify prop TS * [chart] lint * [chart][ts] lint #2, move @types to deps not dev-deps * [chart][jest] fix tests * [chart][tests] up branch coverage * [chart][ts][test] null => undefined * [chart][tests] hundo * [chart][tests] update name * [chart][ts] ChartClient type fixes
This PR attempts to add travis to the build so it fails when prettier, linting, or testing fails.
@kristw @conglei @john-bodley @mistercrunch