This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
feat: allow legend overrides at multiple levels #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for superset-ui-plugins ready! Built with commit c8ff58b |
|
Deploy preview for superset-ui-plugins ready! Built with commit 42318f3 |
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
* feat: reduce legend text size * feat: compute legend data * feat: support multi-level overrides for legend
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🏆 Enhancements
Allow legend overrides at multiple levels:
LegendGroupRender: Each chart may have multiple legend groups if it uses multiple fields to encode.LegendItemRenderer: Each group has one or more item. This will override how to render legend item as a whole.LegendItemMarkRenderer: Override the glyph for each legend itemLegendItemLabelRenderer: Override the label for each legend item