This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
fix(table): TableVis dynamic height enabled #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schillerk
approved these changes
Oct 14, 2019
kristw
approved these changes
Oct 15, 2019
|
Deploy preview for superset-ui-plugins ready! Built with commit edf72bd |
|
@conglei don't forget to mark |
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
=======================================
Coverage 34.25% 34.25%
=======================================
Files 12 12
Lines 216 216
Branches 21 21
=======================================
Hits 74 74
Misses 132 132
Partials 10 10Continue to review full report at Codecov.
|
nytai
pushed a commit
to preset-io/superset-ui-plugins
that referenced
this pull request
Apr 27, 2020
* fix(table): table dynamic height enabled * build(fix storybook): fix storybook lib dep and node version (apache-superset#233) * build(xychart): ignore typing of xychart for now * fix(fix lint): fix lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💔 Breaking Changes
🏆 Enhancements
This PR is to enable the dynamic height for TableVis.
Starting from
lunar 2.35.0,dynamicRowheightis added in<DataTable />.📜 Documentation
🐛 Bug Fix
remove @types/storybook__addon-knobs since typing is supported natively.
bumping node version to 10.15 since eslint6.5 requires it.
🏠 Internal