-
Notifications
You must be signed in to change notification settings - Fork 77
Conversation
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
There seems to be a build issue (not from your PR) that prevents me from seeing the preview. May have to wait until that is resolved. |
all right, looking forward to see the preview |
@kristw is there anythingIi can help to fix the preview? |
@christophlingg Please feel free to open another PR to fix the build. I am out of bandwidth at the moment. |
@kristw all right, I will have a look. can you point me to the right places to not start from zero? |
Please rebase |
1b6e7d7
to
b15ea80
Compare
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
Codecov Report
@@ Coverage Diff @@
## master #215 +/- ##
=======================================
Coverage 34.25% 34.25%
=======================================
Files 12 12
Lines 216 216
Branches 21 21
=======================================
Hits 74 74
Misses 132 132
Partials 10 10 Continue to review full report at Codecov.
|
Deploy preview for superset-ui-plugins ready! Built with commit b15ea80 |
…pache-superset#215) * feat: add Wrapper support and bounding box for dynamic width/height * fix: unit tests * fix: address comments and update unit tests * docs: update storybook
🏆 Enhancements
as discussed in #53 , the world map colors have some issues
this pull requests resolves these issues by
In theory this changes are an essential improvement over the current change. However, this is my first week with superset and it is not clear to me how to run examples locally and tune colors further. Any hint is more than welcome!