Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

feat(datatable): render html correctly #199

Merged
merged 2 commits into from
Sep 12, 2019
Merged

feat(datatable): render html correctly #199

merged 2 commits into from
Sep 12, 2019

Conversation

conglei
Copy link
Contributor

@conglei conglei commented Sep 12, 2019

💔 Breaking Changes

🏆 Enhancements
The pr is to add the capability to render the html correctly. https://github.com/milesj/interweave is used to render the html.

📜 Documentation

🐛 Bug Fix

🏠 Internal

@conglei conglei requested a review from a team as a code owner September 12, 2019 00:01
@netlify
Copy link

netlify bot commented Sep 12, 2019 •
edited
Loading

Deploy preview for superset-ui-plugins ready!

Built with commit d32b2ef

https://deploy-preview-199--superset-ui-plugins.netlify.com

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #199 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   34.25%   34.25%           
=======================================
  Files          12       12           
  Lines         216      216           
  Branches       21       21           
=======================================
  Hits           74       74           
  Misses        132      132           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f93850...d32b2ef. Read the comment docs.

5 similar comments
@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #199 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   34.25%   34.25%           
=======================================
  Files          12       12           
  Lines         216      216           
  Branches       21       21           
=======================================
  Hits           74       74           
  Misses        132      132           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f93850...d32b2ef. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #199 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   34.25%   34.25%           
=======================================
  Files          12       12           
  Lines         216      216           
  Branches       21       21           
=======================================
  Hits           74       74           
  Misses        132      132           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f93850...d32b2ef. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #199 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   34.25%   34.25%           
=======================================
  Files          12       12           
  Lines         216      216           
  Branches       21       21           
=======================================
  Hits           74       74           
  Misses        132      132           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f93850...d32b2ef. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 12, 2019

Codecov Report

Merging #199 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   34.25%   34.25%           
=======================================
  Files          12       12           
  Lines         216      216           
  Branches       21       21           
=======================================
  Hits           74       74           
  Misses        132      132           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f93850...d32b2ef. Read the comment docs.

@codecov
Copy link

codecov bot commented Sep 12, 2019 •
edited
Loading

Codecov Report

Merging #199 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   34.25%   34.25%           
=======================================
  Files          12       12           
  Lines         216      216           
  Branches       21       21           
=======================================
  Hits           74       74           
  Misses        132      132           
  Partials       10       10

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f93850...d32b2ef. Read the comment docs.

@conglei conglei merged commit 170ba7c into master Sep 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the conglei_table_html_format branch September 12, 2019 20:11
nytai pushed a commit to preset-io/superset-ui-plugins that referenced this pull request Apr 27, 2020
@kristw
feat: optimize functions for getting text dimension (apache-superset#199
ad0fa42 
)

* feat: add function for getting multiple text dimensions

* feat: lazy deletion

* feat: use lazy factory

* fix: comments

* fix: rename variable
nytai pushed a commit to preset-io/superset-ui-plugins that referenced this pull request Apr 27, 2020
@conglei
feat(datatable): render html correctly (apache-superset#199)
589024b 
* feat(datatable): render html correctly

n

* fix(sanitize string): sanitize string before parsing

n
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kristw kristw kristw approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@conglei @kristw