Skip to content
This repository has been archived by the owner on Jun 25, 2020. It is now read-only.

fix: show only necessary tick labels on log scale #19

Merged
merged 2 commits into from
Mar 14, 2019
Merged

fix: show only necessary tick labels on log scale #19

merged 2 commits into from
Mar 14, 2019

Conversation

kristw
Copy link
Collaborator

@kristw kristw commented Mar 14, 2019 •
edited
Loading

🐛 Bug Fix

  • For log scale, only show labels for 1, 10, 100, 1000, ...
  • Address Airbnb's PRODUCT-65125

Before

image

After

image

@michellethomas @graceguo-supercat

@kristw kristw requested a review from a team as a code owner March 14, 2019 01:10
@kristw kristw changed the title fix: show only necessary ticks on log scale fix: show only necessary tick labels on log scale Mar 14, 2019
@kristw kristw added #bug Something isn't working reviewable labels Mar 14, 2019
michellethomas
michellethomas approved these changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@michellethomas michellethomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kristw kristw added this to the v0.10.1 milestone Mar 14, 2019
williaster
williaster approved these changes Mar 14, 2019
View reviewed changes
Copy link
Contributor

@williaster williaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bummer we can't write tests for all these great fixes! not worth it given the upcoming replacement vis's, tho :)

@kristw kristw merged commit 2f35d0c into master Mar 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the kristw--log-scale branch March 14, 2019 17:51
nytai referenced this pull request in preset-io/superset-ui-plugins Apr 27, 2020
@kristw
Merge pull request #19 from apache-superset/kristw--new-core
8aad867 
Add new core modules from incubator-superset
nytai referenced this pull request in preset-io/superset-ui-plugins Apr 27, 2020
@kristw
fix: show only necessary tick labels on log scale (#19)
f642031 
* fix: show only necessary ticks on log scale and add storybook

* fix: storybook path
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@williaster williaster williaster approved these changes

@michellethomas michellethomas michellethomas approved these changes

Assignees
No one assigned
Labels
#bug Something isn't working reviewable
Projects
None yet
Milestone
v0.10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@kristw @michellethomas @williaster