This repository has been archived by the owner on Jun 25, 2020. It is now read-only.
fix: dual line chart color consistency for secondary y axis #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michellethomas
approved these changes
Mar 14, 2019
|
Looks like you may need to get someone on |
williaster
approved these changes
Mar 14, 2019
nytai
referenced
this pull request
in preset-io/superset-ui-plugins
Apr 27, 2020
rename core package to connection
nytai
referenced
this pull request
in preset-io/superset-ui-plugins
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Solution
This was due to
nvd3appending' (right axis)'to category name before passing to color function.Before
After
cc: @michellethomas @graceguo-supercat