fix: Line not hidden after legend selection (#204)

* fix: Line not hidden after legend selection * fix: lint issues
apache-superset · Sep 26, 2019 · 484d639 · 484d639
1 parent 6e988aa
commit 484d639
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/packages/superset-ui-legacy-preset-chart-nvd3/src/NVD3Vis.js b/packages/superset-ui-legacy-preset-chart-nvd3/src/NVD3Vis.js
@@ -1080,13 +1080,15 @@ function nvd3Vis(element, props) {
           .call(chart);
 
         // Display styles for Time Series Annotations
-        d3.selectAll('.slice_container .nv-timeseries-annotation-layer.showMarkerstrue .nv-point')
-          .style('stroke-opacity', 1)
-          .style('fill-opacity', 1);
-        d3.selectAll('.slice_container .nv-timeseries-annotation-layer.hideLinetrue').style(
-          'stroke-width',
-          0,
-        );
+        chart.dispatch.on('renderEnd.timeseries-annotation', () => {
+          d3.selectAll('.slice_container .nv-timeseries-annotation-layer.showMarkerstrue .nv-point')
+            .style('stroke-opacity', 1)
+            .style('fill-opacity', 1);
+          d3.selectAll('.slice_container .nv-timeseries-annotation-layer.hideLinetrue').style(
+            'stroke-width',
+            0,
+          );
+        });
       }
     }