Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

Polygon Layer Viewport Change on Filter Set #14

Closed
drunkenmyno opened this issue Apr 6, 2020 · 3 comments
Closed

Polygon Layer Viewport Change on Filter Set #14

drunkenmyno opened this issue Apr 6, 2020 · 3 comments

Comments

@drunkenmyno
Copy link

A clear and concise description of what the bug is.

Expected results
When a Filter is set in a Table for a Polygon Layer.

A Filter is set and the Viewport didnt update.

Error happened

Could not fit viewport Error: @math.gl/web-mercator: assertion failed.

because the Coordiantes are Zero then. after

if (formData.autozoom) {
viewport = fitViewport(viewport, {
width,
height,
points: features.flatMap(getPointsFromPolygon)
});
}

Polygon.js

Actual results
Viewport zooms out to stanrdard 6.85236157047845, 31.222656842808707

How to reproduce the bug
Create a GeoJSON Layer with More then 2 Polygons set a Filter on it.
The Viewport did not update to the Polygon

Environment
superset version: latest
python version: 3.6.4
node.js version: 13
npm version: latest
Checklist
Make sure these boxes are checked before submitting your issue - thank you!

[x ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
[ x] I have reproduced the issue with at least the latest released version of superset.
[x ] I have checked the issue tracker for the same issue and I haven't found one similar.

@drunkenmyno
Copy link
Author

I found the issue that its in computesBoundsfromPoints.js

because the Polygon Array has more then one array and the d3Extent gets calculated wrong then

any idea to fix?

@ktmud ktmud changed the title Polygon Layer Viewport Change on Filtern Set Polygon Layer Viewport Change on Filter Set Apr 18, 2020
@anadue
Copy link

anadue commented May 12, 2021

Has this issue been looked at? We see something similar.

@villebro
Copy link
Contributor

The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: apache/superset#13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this issue on the main repo if it is still relevant.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants