Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SOL] Use R10 as the stack pointer #117

Merged
merged 3 commits into from
Dec 11, 2024
Merged

[SOL] Use R10 as the stack pointer #117

merged 3 commits into from
Dec 11, 2024

Conversation

LucasSte
Copy link
Collaborator

@LucasSte LucasSte commented Dec 9, 2024 •
edited
Loading

We devised a new strategy for dynamic stack frames, as described in SIMD-0166.

  1. R11 is no longer a valid register.
  2. R10 will serve (in SBFv2) as the stack pointer.
  3. Stack pointer modification happens with add64 R10, imm instruction.
  4. Stack frames grow towards lower addresses and frame usage grows downwards likewise.
  5. The stack is aligned at 64.

@LucasSte
Copy link
Collaborator Author

ubuntu-latest runners are now using Ubuntu 24, which was causing errors during the CMake configure step, so I switched the runners to Ubuntu 22.

I shall revert this change when we upgrade to LLVM 19.

@LucasSte LucasSte requested a review from dmakarov December 10, 2024 14:32
@LucasSte LucasSte marked this pull request as ready for review December 10, 2024 14:32
@LucasSte LucasSte merged commit 59716aa into anza-xyz:solana-rustc/18.1-2024-05-19 Dec 11, 2024
20 checks passed
@LucasSte LucasSte deleted the r10-stack-1 branch December 11, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmakarov dmakarov dmakarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucasSte @dmakarov