Bump ed25519-dalek to 2.1.1, ed25519-dalek-bip32 to 0.3.0 #3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
force-pushed
the
ed25519-dalek-2.1.1
branch
3 times, most recently
from
20fa549 to
e26da48
Compare
kevinheavey
force-pushed
the
ed25519-dalek-2.1.1
branch
2 times, most recently
from
da64d7e to
aecdb9b
Compare
kevinheavey
force-pushed
the
ed25519-dalek-2.1.1
branch
3 times, most recently
from
d2fa89a to
713c148
Compare
kevinheavey
force-pushed
the
ed25519-dalek-2.1.1
branch
2 times, most recently
from
06e29a8 to
589a03d
Compare
kevinheavey
force-pushed
the
ed25519-dalek-2.1.1
branch
from
589a03d to
a75f114
Compare
|
Any updates on this? I have a project that would welcome this bump. If there is any way to help out to speed up merging this let me know please. |
|
The main blocker is that this requires a breaking change |
I am not too deep into the repository, but do you expect a resolution of that anytime soon? |
|
they are talking about giving these crates their own release schedule but idk when 🤷♂️ |
kevinheavey
force-pushed
the
ed25519-dalek-2.1.1
branch
from
7a147fc to
36d2615
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Keypair::generatenow relies on traits from a newer version of the rand crate - it no longer works with rand 0.7.This branches off #3087 so that needs to be merged first (update: done).
Thanks to #2752 for figuring out the ed25519-dalek API changes