Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves a clippy attribute #194

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Conversation

brooksprumo
Copy link

Problem

New clippy nighly has a new warning:

warning: item has both inner and outer attributes
   --> memory-management/src/aligned_memory.rs:209:1
    |
209 | / #[cfg(test)]
210 | | mod tests {
211 | |     #![allow(clippy::arithmetic_side_effects)]
    | |______________________________________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mixed_attributes_style
    = note: `#[warn(clippy::mixed_attributes_style)]` on by default

Summary of Changes

Move the attribute.

@brooksprumo brooksprumo self-assigned this Mar 11, 2024
@brooksprumo brooksprumo marked this pull request as ready for review March 11, 2024 22:15
@brooksprumo brooksprumo requested a review from pgarg66 March 11, 2024 22:15
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.9%. Comparing base (e027a8b) to head (62d8d66).
Report is 18 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master     #194    +/-   ##
========================================
  Coverage    81.8%    81.9%            
========================================
  Files         838      837     -1     
  Lines      226389   226502   +113     
========================================
+ Hits       185342   185570   +228     
+ Misses      41047    40932   -115     

@brooksprumo brooksprumo merged commit 0763293 into anza-xyz:master Mar 12, 2024
35 checks passed
@brooksprumo brooksprumo deleted the clippy/math branch March 12, 2024 11:46
codebender828 pushed a commit to codebender828/agave that referenced this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants