ancient_pack: don't sort slots #1743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A follow up of #1730 |
HaoranYi
force-pushed
the
accounts-db/donot_sort
branch
from
3373aa9 to
80e05b5
Compare
HaoranYi
commented
Jun 14, 2024
| @@ -9774,6 +9774,12 @@ pub mod tests { | |||
| fn get_storage_for_slot(&self, slot: Slot) -> Option<Arc<AccountStorageEntry>> { | |||
| self.storage.get_slot_storage_entry(slot) | |||
| } | |||
|
|
|||
| fn get_sorted_potential_ancient_slots(&self, oldest_non_ancient_slot: Slot) -> Vec<Slot> { | |||
There was a problem hiding this comment.
Move the original get_sorted_potential_ancient_slots to test-only context to keep test happy 😄
HaoranYi
force-pushed
the
accounts-db/donot_sort
branch
from
5d90a88 to
46e2531
Compare
HaoranYi
force-pushed
the
accounts-db/donot_sort
branch
from
46e2531 to
5e50b38
Compare
|
won't do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We don't need to sort the slots for ancient storage packing. These slots will
be sorted by different criteria later.
Summary of Changes
Don't sort the slots for ancient storage packing.
Fixes #