blockstore: Remove unnecessary function and threadpool #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is somewhat of a follow on to solana-labs#34768. Namely, that PR removed a threadpool that was used to fetch entries. There is a similar thread pool that is used to fetch entries for the use-case of purging special columns. Regardless of the use-case, the sentiment that we shouldn't be using a threadpool to fetch the entries remains
Summary of Changes
Blockstore::purge_special_columns_exact()
to use the public facing functionallow_dead_slots == true
retains previous functionalityNote that the thread-pool was inside a
lazy_static!
, and would have only been accessed whenBlockstore::clear_unconfirmed_slot()
was called. That function gets called fromReplayStage
when something is wrong (like the node forking off). So, any healthy node should not created this pool. Regardless, it is still good to cleanupWork is part of #35