Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple packages allow solana-program@2 #1869

Closed
Buzzec opened this issue Jun 25, 2024 · 2 comments
Closed

Multiple packages allow solana-program@2 #1869

Buzzec opened this issue Jun 25, 2024 · 2 comments

Comments

@Buzzec
Copy link

Buzzec commented Jun 25, 2024

Problem

[email protected], [email protected], [email protected], [email protected], and [email protected] all depend on solana-program with

[dependencies.solana-program]
version = ">=1.17.17,<=2"

This is incorrect because it allows solana-program@2.

This should be

[dependencies.solana-program]
version = ">=1.17.17,<2"

solana-client@<2 requires these packages and cannot be used anymore. solana-client@>=2 contains compile errors.

Proposed Solution

Yank all crates that could rely on solana-program@2 now that it's published.

Workaround

You can get the lock file to not use solana-program@2 if you first add solana-sdk, build, and then add solana-client. This is a very fickle solution and could break whenever a new update is pushed to any crate.

@acheroncrypto
Copy link

This is an SPL issue an is being tracked in solana-labs/solana-program-library#6897.

@Buzzec
Copy link
Author

Buzzec commented Jul 23, 2024

Closed for solana-labs/solana-program-library#6897

@Buzzec Buzzec closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants