diff --git a/runtime/src/installed_scheduler_pool.rs b/runtime/src/installed_scheduler_pool.rs index d7326da99ef43b..cf5e65b182f588 100644 --- a/runtime/src/installed_scheduler_pool.rs +++ b/runtime/src/installed_scheduler_pool.rs @@ -491,7 +491,8 @@ impl BankWithScheduler { ); assert!( maybe_result_with_timings.is_none(), - "Premature result was returned from scheduler after paused" + "Premature result was returned from scheduler after paused (slot: {})", + bank.slot(), ); } @@ -635,6 +636,11 @@ impl BankWithSchedulerInner { uninstalled_scheduler.return_to_pool(); (false, Some(result_with_timings)) } + SchedulerStatus::Stale(_pool, _result_with_timings) if reason.is_paused() => { + // Do nothing for pauses because the scheduler termination is guaranteed to be + // called later. + (true, None) + } SchedulerStatus::Stale(_pool, _result_with_timings) => { let result_with_timings = scheduler.transition_from_stale_to_unavailable(); (true, Some(result_with_timings)) diff --git a/unified-scheduler-pool/src/lib.rs b/unified-scheduler-pool/src/lib.rs index e1309a6d963694..0f112ac6b03b8b 100644 --- a/unified-scheduler-pool/src/lib.rs +++ b/unified-scheduler-pool/src/lib.rs @@ -1784,6 +1784,50 @@ mod tests { assert_eq!(timings.metrics[ExecuteTimingType::CheckUs], 246); } + #[test] + fn test_scheduler_pause_after_stale() { + solana_logger::setup(); + + let _progress = sleepless_testing::setup(&[ + &TestCheckPoint::BeforeTimeoutListenerTriggered, + &CheckPoint::TimeoutListenerTriggered(0), + &CheckPoint::TimeoutListenerTriggered(1), + &TestCheckPoint::AfterTimeoutListenerTriggered, + ]); + + let ignored_prioritization_fee_cache = Arc::new(PrioritizationFeeCache::new(0u64)); + let pool_raw = DefaultSchedulerPool::do_new( + None, + None, + None, + None, + ignored_prioritization_fee_cache, + SHORTENED_POOL_CLEANER_INTERVAL, + DEFAULT_MAX_POOLING_DURATION, + DEFAULT_MAX_USAGE_QUEUE_COUNT, + SHORTENED_TIMEOUT_DURATION, + ); + let pool = pool_raw.clone(); + + let GenesisConfigInfo { genesis_config, .. } = create_genesis_config(10_000); + let bank = Bank::new_for_tests(&genesis_config); + let bank = setup_dummy_fork_graph(bank); + + let context = SchedulingContext::new(bank.clone()); + + let scheduler = pool.take_scheduler(context); + let bank = BankWithScheduler::new(bank, Some(scheduler)); + pool.register_timeout_listener(bank.create_timeout_listener()); + + sleepless_testing::at(TestCheckPoint::BeforeTimeoutListenerTriggered); + sleepless_testing::at(TestCheckPoint::AfterTimeoutListenerTriggered); + + // this calls register_recent_blockhash internally + bank.fill_bank_with_ticks_for_tests(); + let (result, _timings) = bank.wait_for_completed_scheduler().unwrap(); + assert_matches!(result, Ok(())); + } + #[test] fn test_scheduler_remain_stale_after_error() { solana_logger::setup();