Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lockfile of reverted electron #1061

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

hellodword
Copy link
Contributor


  • I understand that contributing to this repository will require me to agree with the CLA

Description

3e9409b

"electron": "^31.0.2",

"electron": "^33.0.1",

This issue caused compilation errors on some distributions that rely on lockfiles for deterministic builds.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 tech-docs
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/[email protected] environment, filesystem, shell Transitive: network +38 4.38 MB electron-nightly

🚮 Removed packages: npm/[email protected]

View full report↗︎

@ra3orblade ra3orblade merged commit 4881588 into anyproto:main Nov 20, 2024
3 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
@hellodword hellodword deleted the fix-lockfile branch November 20, 2024 16:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants