-
-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: zod additional properties error #972
Closed
CxGarcia
wants to merge
7
commits into
orval-labs:master
from
CxGarcia:fix/zod-additional-properties
Closed
fix: zod additional properties error #972
CxGarcia
wants to merge
7
commits into
orval-labs:master
from
CxGarcia:fix/zod-additional-properties
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Someone is attempting to deploy a commit to a Personal Account owned by @anymaniax on Vercel. @anymaniax first needs to authorize it. |
CxGarcia
changed the title
fix: zod additional properties
fix: zod additional properties error
Oct 19, 2023
melloware
requested changes
Oct 19, 2023
melloware
previously approved these changes
Oct 19, 2023
melloware
force-pushed
the
fix/zod-additional-properties
branch
from
October 26, 2023 11:57
2300d2c
to
e3a01cd
Compare
Looks like tests are failing? |
melloware
requested changes
Nov 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are still failing...
Errors...
|
@soartec-lab i am closing this one. The new PR is the correct solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
in zod generator, the
additionalProperties
that are appended to functions array are either anarray
or aboolean
(see code). however,parseProperty
function is treating them all as arrays and using array methods which causes a runtime error. you can reproduce the error by running zod generator on this filethis PR fixes the error and uses the
passthrough
method whenadditionalProperties
are set totrue
to avoid unknown keys being stripped from the object by zodTodos
Steps to Test or Reproduce