Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): use non-barrel schema file imports when using split-tags mode #1110

Merged
merged 1 commit into from
Dec 13, 2023
Merged

fix(core): use non-barrel schema file imports when using split-tags mode #1110

merged 1 commit into from
Dec 13, 2023

Conversation

codebutler
Copy link
Contributor

@codebutler codebutler commented Dec 12, 2023 •
edited
Loading

Status

READY

Description

Fixes bad code generation when using indexFiles: false.

Related PRs

N/A

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

Steps to Test or Reproduce

Run orval with a configuration like:

{
  mode: "tags-split",
  target: "src/gen/endpoints/api.ts",
  schemas: "src/gen/model",
  indexFiles: false,
}

fix(core): use non-barrel schema file imports when using split-tags mode
e3eb63e 
fixes bad code generation when using `indexFiles: false`
@melloware melloware added the bug Something isn't working label Dec 12, 2023
@melloware melloware added this to the 6.23.0 milestone Dec 12, 2023
@codebutler codebutler merged commit 92b0179 into orval-labs:master Dec 13, 2023
2 checks passed
@codebutler codebutler deleted the split-tags-import-directly branch December 13, 2023 17:15
@soartec-lab soartec-lab mentioned this pull request Dec 28, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melloware melloware melloware approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
6.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@codebutler @melloware