fix: handle empty response in MSW mocks #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlismelderis-mckinsey
force-pushed
the
fix/handle-null-in-msw-mock
branch
from
0017e56 to
fa6ac2f
Compare
|
|
karlismelderis-mckinsey
changed the title
|
Hey @melloware , I checked the source only, it makes sense to me, but I don't use orval for MSW. I also didn't check changes to samples. Hope this helps, cheers! |
melloware
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
if response body is empty (aka zero bytes) then
Content-Typecannot beapplication/jsonas zero bytes cannot be parsed to JSON