Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: VueJS infinite query parameters reactivity when hasInfiniteQueryParam #1379

Merged
merged 1 commit into from
May 21, 2024

Conversation

Skanislav
Copy link
Contributor

@Skanislav Skanislav commented May 15, 2024

Status

READY

UPD:

Samples updated here: https://github.com/soartec-lab/orval/blob/eecc2622a211d52f27804294a228cf1cd4eda659/samples/vue-query/src/api/endpoints/petstoreFromFileSpecWithTransformer.ts

Description

Fix #1378 for detailed issue description

Todos

  • Tests
  • Documentation
  • Changelog Entry (unreleased)

Steps to Test or Reproduce

@melloware melloware requested a review from Maxim-Mazurok May 15, 2024 16:52
@melloware
Copy link
Collaborator

Assigned @Maxim-Mazurok he is the Vue expert.

@Skanislav
Copy link
Contributor Author

Thanks, after confirmation of fix I can try to add a test for that

@melloware melloware added the tanstack-query TanStack Query related issue label May 16, 2024
@Skanislav
Copy link
Contributor Author

Hey @Maxim-Mazurok, is there anything I can do to speed things up on this one? I checked the existing tests and didn't find any for the useInfiniteQuery implementation. That's probably because this bug wasn't spotted for a long time

@melloware
Copy link
Collaborator

LGTM I will merge. If @Maxim-Mazurok had and issue we can always fix again.

@melloware melloware merged commit c1adaf7 into orval-labs:master May 21, 2024
2 checks passed
@Maxim-Mazurok
Copy link
Contributor

Maxim-Mazurok commented May 21, 2024

Hey guys, don't have much time for OSS lately, so probably do not assign me to reviews for now... We do update orval periodically, and I check if generated files changed, and we have pretty good test coverage, so if there will be any bugs - I'll report back to the repo. I did update one of the projects to the latest orval recently and there were no issues.

As for infinite query, very likely that we missed it, as we don't use infinite query feature. So this probably makes sense. I would suggest creating a functional test in the future, I remember adding a few for the vue query sample. Hope this helps, cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tanstack-query TanStack Query related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-reactive query params in Vue when using useInfiniteQueryParam
3 participants