feat(msw): make delay optional

[AllieJonsson]

Status

READY

Description

This allows disabling the delay call in mocked api calls, which makes the MockHandler sync instead of async.
As per request of Nate on discord

Todos

• Tests
• Documentation
• Changelog Entry (unreleased)

Steps to Test or Reproduce

Make sure delay still can be set by both number and function and that the MockHandler is async.
Try changing the delay settings to false and make sure the MockHandlers become synchronous and no call to delay is made.

[AllieJonsson]

A bit unsure about this, but it feels like override always should override when present, and not only when it's overridden by a number?

[melloware]

Good question. Not sure why this decision was made?

[AllieJonsson]

Maybe it was missed when support for functions was added?

[soartec-lab]

@AffeJonsson
Thank you for the nice update. I made a comment in one place, so please check it.

[soartec-lab]

I thought that the definition itself is unnecessary if delay is false, but what do you think?

Suggested change

	return http.${verb}('${route}', ${
	delay === false
	? '() => {'
	: `async () => {
	await delay(${isFunction(delay) ? `(${delay})()` : delay});`
	}
	return http.${verb}('${route}', ${
	delay === isFunction(delay) || isNumber(delay)
	? `async () => {
	await delay(${isFunction(delay) ? `(${delay})()` : delay});`
	: ''
	}

[AllieJonsson]

No, the second argument to http.get must be a function, so we cannot remove the () => {

[AllieJonsson]

This is how the mock handler looks with delay: false

[soartec-lab]

Oh, that's nice. That's what I wanted.

[soartec-lab]

Thanks!