fix(msw): correctly mock nested objects #1325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Fixes #1210
This fixes the issue with nested objects that are more than one level deep (in petstore, there is an example of Pet, which is one of Dog or Cat, and Dog is one of Labradoodle or Dachshund). There is a problem where only the last oneOf object gets the base object properties. This PR fixes this issue, more info in linked issue.
Steps to Test or Reproduce
Before new code: go to tests/generated/swr/petstore/endpoints.ts, notice how
getListPetsResponseMock
contains:Notice that the first object is missing '@id', callingCode, country, email, id, name and tag.
With new code, do the same generation and check the same file. See that the missing properties are now present in the first object.